[MPlayer-cvslog] r18867 - trunk/libmpcodecs/vd_odivx.c

[Guillaume POIRIER]

Hi,

On 6/30/06, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Jun 30, 2006 at 02:41:50PM +0200, Guillaume POIRIER wrote:
> >
> > On 6/30/06, diego <subversion at mplayerhq.hu> wrote:
> > >Author: diego
> > >Date: Fri Jun 30 14:38:22 2006
> > >New Revision: 18867
> > >
> > >Modified:
> > >   trunk/libmpcodecs/vd_odivx.c
> > >
> > >Log:
> > >postprocess.h was moved to libpostproc years ago..
> >
> > Given that I don't recall builds to fail because of a missing
> > definition when compiling  vd_odivx, it looks like this include is
> > useless and should be removed, don't you think? (the other way to
> > explain this is to say that no one even tried to compile this for
> > ages).
>
> I'll bet you a dollar that the latter is the case.  Nobody has built
> this for *years*.  It makes me think we should remove this old cruft.

s/dollar/euro/ (that way you don't have to pay the bank fees and shit).

I also vote for removing it. Ivan will probably object, but hey, when
open source solutions are better in ever single way (performance,
multi-platform, error-resilience, ... ) than closed sourced, I don't
see any reason to continue to support them.

Guillaume
-- 
"If God had wanted us to vote, he would have given us candidates."
  - Jay Leno