[MPlayer-cvslog] r18780 - trunk/mplayer.c

[Michael Niedermayer]

Hi

On Thu, Jun 22, 2006 at 12:06:05AM +0300, Uoti Urpala wrote:
> On Wed, 2006-06-21 at 22:29 +0200, michael wrote:
> > Log:
> > send flip_page() through the filter chain
> > ignoring the filter chain cannot and does not work with frame skip / insertion filters
> > if this breaks something then just reverse it, ive not exhaustively tested it ...
> 
> I think this is wrong, even though it might not break anything now. At
> least it's not the right way to do what you implemented for vf_framestep
> - the basic frame skip or insertion functionality cannot be based on
> flip_page(). If a frame is skipped the main loop should know about it
> before sleeping to time it. If a new frame is inserted by a filter the
> main loop also needs to know about that so it won't feed more data to
> the demuxer yet.

feel free to reverse and or implement it better, i simply dont understand
the mplayer architecture well enough and dont have the time/motivation to
RTFS the whole related code, which is IMHO quite alot of code


> 
> Does this even do anything useful with vf_framestep? There's already the

fixes yadif=3,framestep=2 and tfields=1:1,framestep=2 and others

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is