[MPlayer-cvslog] r18744 - trunk/configure

[Rich Felker]

On Tue, Jun 20, 2006 at 09:44:41PM +0300, Ivan Kalvachev wrote:
> 2006/6/20, Rich Felker <dalias at aerifal.cx>:
> >On Sat, Jun 17, 2006 at 07:18:47PM +0200, diego wrote:
> >> Author: diego
> >> Date: Sat Jun 17 19:18:46 2006
> >> New Revision: 18744
> >>
> >> Modified:
> >>    trunk/configure
> >>
> >> Log:
> >> Rename --with-libdvnav --> --with-dvdnavdir for consistency.
> >>
> >>
> >> Modified: trunk/configure
> >> 
> >==============================================================================
> >> --- trunk/configure   (original)
> >> +++ trunk/configure   Sat Jun 17 19:18:46 2006
> >> @@ -2019,7 +2019,7 @@
> >>    --language=*)
> >>      _language=`echo $ac_option | cut -d '=' -f 2`
> >>      ;;
> >> -  --with-libdvdnav=*)
> >> +  --with-dvdnavdir=*)
> >>      _dvdnavdir=`echo $ac_option | cut -d '=' -f 2`
> >
> >I thought we were going to remove all this crap and tell people to use
> >extraincdir/extralibdir instead. The current form is misleading,
> >bloated, painful to maintain, and not useful.
> 
> Is it possible to give more than one directory with --extrainc/libdir?

Yes, IIRC they're separated by commas. RTFS I guess. We should improve
the comment for them..

> I thought the purpose of having specific --with-s is to pass the
> include/library path only to the module that needs it. (having 10

This is possible but not done for include paths, and completely
impossible for library paths. It's very misleading and thus violates
the principle of least surprise. --with-dvdnavdir implies that the
path you specify will only be searched for libdvdnav, but in reality
the linker will search that path for ALL LIBRARIES, possibly giving
very unexpected behavior to users who do not understand linking.

Rich