[MPlayer-cvslog] r18718 - in trunk/libvo: vo_x11.c vo_xmga.c vo_xv.c vo_xvidix.c vo_xvmc.c x11_common.c

[The Wanderer]

Tomáš Janoušek wrote:

> Hello,
> 
> Sat, Jun 17, 2006 at 09:49:11PM +0200  Reimar Döffinger napsal:
> 
>> Well, I'm looking for a consistent fix for all cases *g*
> 
> I've got a perfect idea! :)
> 
> With my patch to keep the video aspect right regardless of window
> size by adding black bars (well, my patch is vo_gl specific and
> crappy at all, but imagine we have got this working), we could keep
> the window position and _size_. This, imho, completely resembles the
> logic 'user has set the window position and size to what he likes and
> we keep it'.

The problem with that is that it doesn't work well in the case he
specifically described of "small window positioned near the edge of the
screen means large window positioned partly off the screen"; I know of
no obvious fix for that other than adding new options as I suggested.

This doesn't mean that *I*'m opposed to it - indeed, since the original
misbehaviour occurs in far fewer cases than the new (only when using
-fixed-vo and changing back from fullscreen on a non-first video in a
chain of multiple, vs. all the time no matter what), I'd be in favor of
simply reverting this commit until we can figure out a proper solution.
My opinion, however, doesn't mean that I can't see or acknowledge the
arguments against it.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.