[MPlayer-cvslog] r18677 - trunk/libvo/gl_common.c

[Jindrich Makovicka]

On Sun, 11 Jun 2006 19:22:14 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hi,
> On Sun, Jun 11, 2006 at 06:46:03PM +0200, Jindrich Makovicka wrote:
> > Nice stuff, but the yuv table generation is quite slow. I tried to
> > combine it with gen_gamma_map() and it made quite a difference. So
> > now I can control the brightness interactively without blocking the
> > playback.
> 
> Does this yuv2rgb mode have any advantage for you?

At the second glance it actually doesn't differ from yuv=4
performance-wise, at least on a 6600gt. So it was rather a wishful
thinking :)

> Either way, I'll have a look at it again after the release, it might
> make sense to make the gamma map larger, as in difference to the
> graphics hardware the gen_yuv2rgb_map does not do linear
> interpolation. There are certainly some other optimization
> possibilites as well, not sure if it's worth the effor though.

The u_ and v_ calculation could be also moved out of the innermost loop,
but fortunately gcc seems to be smart enough to get it.

-- 
Jindrich Makovicka