[MPlayer-cvslog] r19182 - trunk/TOOLS/mphelp_check.py

[Rich Felker]

On Tue, Jul 25, 2006 at 09:08:34AM +0200, uau wrote:
> Author: uau
> Date: Tue Jul 25 09:08:34 2006
> New Revision: 19182
> 
> Modified:
>    trunk/TOOLS/mphelp_check.py
> 
> Log:
> Regular expression for conversions had 'P' instead of 'p', fixed
> to recognize %p.
> 
> 
> Modified: trunk/TOOLS/mphelp_check.py
> ==============================================================================
> --- trunk/TOOLS/mphelp_check.py	(original)
> +++ trunk/TOOLS/mphelp_check.py	Tue Jul 25 09:08:34 2006
> @@ -30,7 +30,7 @@
>      return r
>  
>  def compare(base, other, show_missing=False):
> -    r = re.compile('%[^diouxXeEfFgGaAcsPn%]*[diouxXeEfFgGaAcsPn%]')
> +    r = re.compile('%[^diouxXeEfFgGaAcspn%]*[diouxXeEfFgGaAcspn%]')

I haven't looked at the code, but this regex looks a bit odd.. Why not
%([0-9][$])?['-+ #0]*[0-9]*[.]?[0-9]*(hh?|ll?|j|z|t|L)?[diouxXeEfFgGaAcspn%]
or something like that? :)

Of course I suppose the current one will work too as long as all
format strings are valid... :)

Rich