[MPlayer-cvslog] r19217 - trunk/libmpdemux/demux_avs.c

[Reimar Döffinger]

Hello,
On Fri, Jul 28, 2006 at 06:16:47PM +0300, Uoti Urpala wrote:
> On Fri, 2006-07-28 at 16:44 +0200, reimar wrote:
> > -        d_video->pts=AVS->frameno / sh_video->fps; // OSD
> > +        dp->pts=AVS->frameno / sh_video->fps;
> 
> If fps has float precision then this should have the (double) cast
> mentioned on mplayer-dev-eng. If the value of fps is slightly inaccurate
> that at most makes the timestamps become consistently too small or big
> the further you go in the file, but if the division is also done with
> float accuracy that causes similar size errors in the duration of
> individual frames. Of course using double for fps might be a better
> solution.

I have no idea what sh_video->fps is, if it was finally changed to
double. But I think this will be replaced by AVS->fps in some later
patch, which will be double.
Also I think that the precision of the division does not matter much,
since the jitter due to waiting for vsync is very likely much more than
this. An error in the fps value on the other hand could cause A-V desync
in the long term when transcoding with mencoder.

Greetings,
Reimar Döffinger