[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Diego Biurrun]

On Wed, Jul 26, 2006 at 11:50:12PM +0200, Michael Niedermayer wrote:
> 
> On Wed, Jul 26, 2006 at 09:50:49PM +0200, Reimar Döffinger wrote:
> [...]
> > > > +	if (sh_audio->i_bps)
> > > >  	a_pts += (ds_tell_pts(d_audio) - sh_audio->a_in_buffer_len) /
> > > >  	    (double)sh_audio->i_bps;
> > > 
> > > Fix the indentation after changes like this. Do another commit if you
> > > insist on separating cosmetic changes (though for a minimal block like
> > > this it's IMO more work for both the committer and possible reviewers to
> > > go through 2 commits), but at least do it somehow instead of letting the
> > > sources rot.
> > 
> > Well, for me it makes not a big change in readability, so I didn't
> > bother. And since the indentation is a mixture of tabs and spaces (first
> > level is 4 spaces, second is one tab), I don't really know how I am
> > supposed to fix it.
> 
> replace all tabs by spaces, add a "marker" at the top like //forbid tabs
> and add a check in the precommit script so that files with "//forbid tabs"
> at the top may not contain tabs ....
> just IMHO of course ...

I'm all for it ;)

Diego