[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Uoti Urpala]

On Wed, 2006-07-26 at 21:50 +0200, Reimar Döffinger wrote:
> On Wed, Jul 26, 2006 at 10:39:46PM +0300, Uoti Urpala wrote:
> > Most decoders also set it. Did you encounter a divide by zero with some
> > combination?
> 
> No, it won't since those are floats. Instead the current time is
> displayed as "inf".

Float divide by zero can raise an interrupt too (though I'm not sure
whether it happens by default on any current platform). Anyway I mainly
meant to ask what the combination was, as av sync will likely be off if
the decoder is using the old pts calculation method.

> Well, for me it makes not a big change in readability, so I didn't
> bother. And since the indentation is a mixture of tabs and spaces (first
> level is 4 spaces, second is one tab), I don't really know how I am
> supposed to fix it.

4 spaces per indent level, spaces to a tab stop replaced with a tab in
this case (it was written in the default xemacs indent mode). Is a tab
for 8 spaces that surprising? If you want to use spaces only that's OK
too.

> Though I can send patches for such stuff (at least when it concerns your
> code) and you can fix it all in the way you like it :-).

I don't see how sending patches instead of committing would help
anything, except possibly reduce the total number of commits.