[MPlayer-cvslog] CVS: main/etc example.conf,1.68,1.69

Ivan Kalvachev ikalvachev at gmail.com
Wed Jan 18 16:24:07 CET 2006


2006/1/18, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Wed, Jan 18, 2006 at 02:20:59PM +0200, Ivan Kalvachev wrote:
> > What the hell are you doing?
> > You have 4 commits in a row for a same file and you make 2 times
> > cosmetic changes and 2 times clarify same things. All of them for less
> > than hour?
> >
> > Are you going to commit contest or something?
>
> diego is just spliting unrelated things, like it should be done
> if you dont like it, dont read it, unsubscribe or fork ...
>

Thank you for the support.

Cosmetic changes are done last after function changes to minimize the
trackback polution.
You simply flooded it. And made cosmetic twice. My guess is that you
haven't finished editing it before you start commiting.

Here is what catched by eye, and i don't think these are unreleated.

//---------------------
cosmetic whitespace / layout changes

+# Specify your preferred default skin here
+# (skins are searched for in /usr/local/share/mplayer/Skin/
+# and ~/.mplayer/Skin/).
+#
+#skin = Abyss
-##
-## Specify your preferred default skin here
-## (skins are searched for in /usr/local/share/mplayer/Skin/
-##  and ~/.mplayer/Skin/).
-##
-# skin = Abyss

//------------------
Improve option descriptions.

-# Specify your preferred default skin here
-# (skins are searched for in /usr/local/share/mplayer/Skin/
-# and ~/.mplayer/Skin/).
-#
+# Specify your preferred skin here (skins are searched for in
+# /usr/local/share/mplayer/Skin/<name> and ~/.mplayer/Skin/<name>).
 #skin = Abyss

//--------------------
Put settings into a more meaningful order, some cosmetics.

-# Specify your preferred skin here (skins are searched for in
-# /usr/local/share/mplayer/Skin/<name> and ~/.mplayer/Skin/<name>).
-#skin = Abyss
...

Whatever... man cannot put a joke anymore...




More information about the MPlayer-cvslog mailing list