[MPlayer-cvslog] CVS: main/mp3lib sr1.c,1.33,1.34

Guillaume POIRIER poirierg at gmail.com
Tue Jan 3 23:08:01 CET 2006


Hi,

On 12/31/05, Guillaume Poirier CVS <syncmail at mplayerhq.hu> wrote:
> CVS change done by Guillaume Poirier CVS
>
> Update of /cvsroot/mplayer/main/mp3lib
> In directory mail:/var2/tmp/cvs-serv74/mp3lib
>
> Modified Files:
>         sr1.c
> Log Message:
> "Currently mplayer looks for only one MP3 frame sync. The attached
> patch makes it to look for two consecutive valid MP3 frame headers,
> reducing the probability of false positives, which causes Bug 380.

Patch reversed.

This was an incorrect fix made at the codec when it should be done at
the demuxer level.
static variables in codecs are ALWAYS wrong: the demuxer is supposed
to have already removed all the junk
(discussed on IRC).

Guillaume
--
Life is pleasant. Death is peaceful. It's the transition that's troublesome.
    Isaac Asimov (1920 - 1992)

MPlayer's doc is offline. Find some fresh one here:
http://tuxrip.free.fr//MPlayer-DOCS-HTML/en/
http://tuxrip.free.fr//MPlayer-DOCS-HTML/fr/




More information about the MPlayer-cvslog mailing list