[MPlayer-cvslog] CVS: main/libvo font_load.h, 1.13, 1.14 font_load_ft.c, 1.16, 1.17 gl_common.c, 1.40, 1.41 gl_common.h, 1.24, 1.25 osd.c, 1.24, 1.25 osd.h, 1.4, 1.5 sub.c, 1.82, 1.83 sub.h, 1.30, 1.31 video_out.c, 1.103, 1.104 video_out.h, 1.62, 1.63 vo_aa.c, 1.47, 1.48 vo_cvidix.c, 1.16, 1.17 vo_gl.c, 1.113, 1.114 vo_gl2.c, 1.86, 1.87 vo_x11.c, 1.144, 1.145 x11_common.c, 1.203, 1.204 x11_common.h, 1.44, 1.45

[Reimar at mplayerhq.hu]

Hi,
On Thu, Feb 09, 2006 at 03:08:34PM +0100, Dominik Mierzejewski CVS wrote:
> Patch by Stefan Huehner / stefan % huehner ! org \
> 
> patch replaces '()' for the correct '(void)' in function
> declarations/prototypes which have no parameters. The '()' syntax tell
> thats there is a variable list of arguments, so that the compiler cannot
> check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
> 
> Comments about a similar patch applied to ffmpeg:
> 
> That in C++ these mean the same, but in ANSI C the semantics are
> different; function() is an (obsolete) K&R C style forward declaration,
> it basically means that the function can have any number and any types
> of parameters, effectively completely preventing the compiler from doing
> any sort of type checking. -- Erik Slagter
> 
> Defining functions with unspecified arguments is allowed but bad.
> With arguments unspecified the compiler can't report an error/warning
> if the function is called with incorrect arguments. -- Måns Rullgård

Please avaoid such long commit messages, it makes cvs log really hard to
read. 5 lines really should be the absolute maximum IMHO.
If more explanation is needed, it should be on the list or in the code
itself.

Greetings,
Reimar Doeffinger