[MPlayer-cvslog] r21666 - trunk/libmpdemux/demux_audio.c

[Michael Niedermayer]

Hi

On Thu, Dec 21, 2006 at 09:21:17PM -0500, Rich Felker wrote:
[...]
> > > And yes if this will misdetect other files then the mp3 detection
> > > needs to be moved later in the sequence, but not crippled like this!
> > 
> > All demuxers can misdetect with format like MXF that allow random crap
> > at the start of the file, so should we now try to put all last? Seems
> > difficult to do...
> > And moving it below lavf is pointless, then we can just rm it.
> > How about a patch with a proper solution instead of just stating the
> > obvious?
> 
> :)
> Eventually removing all but lavf would be nice...

yes, so why not replace the probing code in mplayer by lavf?
lavf would figure out what a stream is, and mplayer then could use its own
demuxers or lavf or anything else as it sees fit ...

lavfs probing code is quite a bit cleaner then the monolithic long list
of checks, first one which thinks is matching is taken system mplayer
uses, in lavf each probe function returns a score
all are tried (it would be a trivial 1 line change to add a early stop
with a threshold)
if the best is below a threshold the probe buffer size is doubled and
the thing is retried
else the best is used

with such a score its trivial to return a low score if only a single valid
frame is found or if the frames dont start at pos=0 ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20061222/0126b50a/attachment.pgp>