[MPlayer-cvslog] r21689 - trunk/stream/stream_file.c

[Aurelien Jacobs]

On Thu, 21 Dec 2006 22:58:43 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> On Thu, Dec 21, 2006 at 08:56:05PM +0100, Nico Sabbi wrote:
> > Reimar Döffinger wrote:
> > >On Tue, Dec 19, 2006 at 10:11:59PM +0100, nicodvb wrote:
> > >>Author: nicodvb
> > >>Date: Tue Dec 19 22:11:58 2006
> > >>New Revision: 21689
> > >>
> > >>Modified:
> > >>  trunk/stream/stream_file.c
> > >>
> > >>Log:
> > >>in WRITE mode open the output file with mode 0666; umask will filter it
> > >>
> > >>Modified: trunk/stream/stream_file.c
> > >>==============================================================================
> > >>--- trunk/stream/stream_file.c	(original)
> > >>+++ trunk/stream/stream_file.c	Tue Dec 19 22:11:58 2006
> > >>@@ -136,7 +136,7 @@
> > >>    if(mode == STREAM_READ)
> > >>      f=open(filename,m);
> > >>    else
> > >>-      f=open(filename,m, S_IRUSR|S_IWUSR);
> > >>+      f=open(filename,m, 
> > >>S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH);
> > >
> > >Breaks MinGW compilation, S_IRGRP, S_IWGRP, S_IROTH and S_IWOTH are not
> > >defined.
> > 
> > what does it offer?
> 
> S_IEXEC, S_IWRITE, S_IREAD, S_IRWXU, S_IXUSR, S_IWUSR and S_IRUSR.
> No idea how to fix without making it a hack.

Why not simply use:
  f=open(filename,m,0666);

Aurel