[MPlayer-cvslog] r21600 - trunk/libvo/vo_x11.c

Rich Felker dalias at aerifal.cx
Wed Dec 13 19:55:25 CET 2006


On Tue, Dec 12, 2006 at 07:43:11PM +0100, reimar wrote:
> Author: reimar
> Date: Tue Dec 12 19:43:10 2006
> New Revision: 21600
> 
> Modified:
>    trunk/libvo/vo_x11.c
> 
> Log:
> Use XCreateImage instead of XGetImage, this is not only more correct and
> similar to the SHM case, it also eliminates the massive startup delay over
> ssh (at least when you have a tiny upstream).

According to my reading of the Xlib docs, it's legal (and preferable)
to just setup the XImage struct yourself rather than obtaining it from
XCreateImage. This way you have more control and you don't have to
worry about nasty issues of Xlib trying to free your buffer when you
destroy the image (because it never has to be destroyed).

Anyone else know about this and if it's correct? That's how I do it in
uuterm.

Rich




More information about the MPlayer-cvslog mailing list