[MPlayer-cvslog] r19535 - in trunk: libmenu/menu_param.c mplayer.c

[Benjamin Zores]

On Fri, 25 Aug 2006 21:57:51 +0200
Nico Sabbi <nicola_sabbi at fastwebnet.it> wrote:

> >+demuxer_t *get_current_demuxer (void) {
> >+  return demuxer;
> >+}
> >+

> this is horrid!!!

I need to retrieve info from demuxer (not only sh_video) from libmenu.
As discussed with you on irc, 3 solutions to that:

1. mark demuxer var from mplayer.c _non_ static
2. use the previous way to get acces to.
3. add functions to mplayer.c to retrieve these infos and extern/call them from libmenu.

Both ways have cons.

1. adds one more global to mplayer.c
2. adds an ugly function indeed
3. adds more code to mplayer.c

Let's vote.
I may implement #3 if other people want to / think it's better.
Unless someone has a better idea for that purpose.
It'll be on tomorrow though.

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama