[MPlayer-cvslog] r19456 - trunk/configure

[The Wanderer]

Diego Biurrun wrote:

> On Sat, Aug 19, 2006 at 06:20:08PM -0400, The Wanderer wrote:
> 
>> Diego Biurrun wrote:
>> 
>>> On Sat, Aug 19, 2006 at 09:10:27PM +0200, iive wrote:

>>>> --- trunk/configure	(original)
>>>> +++ trunk/configure	Sat Aug 19 21:10:27 2006
>>>> @@ -3825,15 +3825,15 @@
>>>> else
>>>> +  _xv=no
>>>>   _def_xv='#undef HAVE_XV'
>>>>   _novomodules="xv $_novomodules"
>>>> fi
>>>> @@ -3878,13 +3878,13 @@
>>>> else
>>>> +  _xinerama=no
>>>>   _def_xinerama='#undef HAVE_XINERAMA'
>>>> fi
>>>> echores "$_xinerama"
>>>
>>> Both of these are unnecessary, please remove them again. These
>>> else cases can only be reached if those variables are already set
>>> to no.
>> 
>> I don't think that's true. What about the case where _x11 is not
>> 'yes' and _xv is 'auto'? The Xv detection will not be run, _xv will
>> not be changed, and so it will still be 'auto' here; at a glance,
>> the Xinerama case is parallel.
> 
> _xv is only tested for yes below.

Correct. However, there is also an 'echores "$_xv"', which AIUI will
print "Checking for Xv... auto" in the case given. I don't think that
that's desirable.

(In any case, unless I've misunderstood you the original statement that
"the else case can only be reached if the variable is already set to no"
doesn't seem to be true.)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.