[MPlayer-cvslog] r19439 - trunk/configure

Ivan Kalvachev ikalvachev at gmail.com
Sat Aug 19 20:50:52 CEST 2006


2006/8/18, diego <subversion at mplayerhq.hu>:
> Author: diego
> Date: Fri Aug 18 18:04:16 2006
> New Revision: 19439
>
> Modified:
>    trunk/configure
>
> Log:
> Some more consistency for the conditions under which tests are run.
>
>
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure     (original)
> +++ trunk/configure     Fri Aug 18 18:04:16 2006
> @@ -1701,7 +1701,7 @@
>  _ftp=yes
>  _musepack=auto
>  _vstream=auto
> -_pthreads=yes
> +_pthreads=auto
>  _ass=auto
>  _rpath=no
>  _asmalign_pot=auto
> @@ -2738,7 +2738,7 @@
>  fi
>
>  _def_use_aton='#undef USE_ATON'
> -if test "$_use_aton" != no; then
> +if test "$_use_aton" = yes; then
>    _def_use_aton='#define USE_ATON 1'
>  fi
>
> @@ -2943,7 +2943,7 @@
>  _def_threads='#undef HAVE_THREADS'
>
>  echocheck "pthread"
> -if test "$_pthreads" != no ; then
> +if test "$_pthreads" = auto ; then
>  cat > $TMPC << EOF
>  #include <pthread.h>
>  void* func(void *arg) { return arg; }
> @@ -3814,7 +3814,7 @@
>
>
>  echocheck "Xv"
> -if test "$_x11" = yes && test "$_xv" != no ; then
> +if test "$_x11" = yes && test "$_xv" = auto ; then

Would you revert this?
If you put -enable-xv in the configure this check would fail (_xv=yes)
and would set _xv=no. Doing exactly the opposite of what it should do.

I guess there are numerous other similar errors. (xinerama?)

Consistency of the semantics should be well though. :E



More information about the MPlayer-cvslog mailing list