[MPlayer-cvslog] r19388 - trunk/DOCS/tech/svn-howto.txt

[Uoti Urpala]

On Mon, 2006-08-14 at 00:14 +0200, michael wrote:
> +  So if the change was completly broken like reindenting a file against the
> +  maintainers decission, or a change which mixed functional and cosmetic
> +  changes then its better if its not part of the vissible history as it
> +  would make it hard to read, review and would also break svn annotate

IMO "mixed functional and cosmetic changes" is not a sufficient reason
to use the delete-and-resurrect-old method. Bad reindent might possibly
be if it changed most lines in a big file.

> +  One method to decide which reversal method is best is to ask yourself
> +  if theres any value in seeing the whole bad change and its removial
> +  in svn vs. just seeing a comment that says what has been reversed while
> +  the actual change does not clutter the immedeatly vissible history and
> +  svn annotate.

Small changes should always be reverted by committing the previous
version regardless of how stupid or worthless they are.

> +  If you are even just slightly uncertain how to revert something then ask on
> +  the mplayer-dev mailinglist.

For small changes it's safe to assume you should do a normal commit. Big
changes will likely get discussed on the mailing list regardless
(whether you should try a quick fix before that depends...).