[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Michael Niedermayer]

Hi

On Sun, Aug 13, 2006 at 03:08:27PM +0200, Roberto Togni wrote:
> On Sun, 13 Aug 2006 11:12:04 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> [...]
> > 
> > So given that three active developers agree that such a thing is
> > desirable, is it time to discuss some sort of style guidelines?
> > 
> 
> I'm against it, unless you can enable it on single files: 

i second that


> but  probably
> even in this case you'll have to allow every developer to enforce his
> own style, and have a list where the requirements for every guarded
> file are clearly stated.

for example at the top of the individual files like
//stylerules:notabs,notrailingwhite,ascii


[...]
> - pre commit scripts are imo very annoying, especially if they don't
> point out exactly what is wrong and where the problem is; 

fully agree, the script must print description & line number

[...]


> 
> 
> But there's a thing that worries me, not related only to this specific
> subject: MPlayer was developed for years with few, simple rules; why
> now we have the need to regulate every single detail of development?

hmm, the way i saw this precommit check was more as a tool to prevent
unintentional adding tabs or such not to somehow restrict what mplayer
developers really would want to conciously do

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is