[MPlayer-cvslog] r19341 - in trunk/stream: Makefile asf_mmst_streaming.c asf_streaming.c network.c network.h pnm.c stream_ftp.c stream_netstream.c stream_rtsp.c stream_vstream.c tcp.c tcp.h

[Michael Niedermayer]

Hi

On Wed, Aug 09, 2006 at 06:03:44PM +0300, Ivan Kalvachev wrote:
> 2006/8/6, Diego Biurrun <diego at biurrun.de>:
> >On Sat, Aug 05, 2006 at 07:50:26PM +0200, Dominik 'Rathann' Mierzejewski 
> >wrote:
> >>
> >> Instead of apologising (which is nice), why don't you
> >> go back and fix what you did wrong (which is useful).
> >> You were already given some tips on how to do this.
> >
> >I've told Ben to hold off for the moment while I investigate this.

could you elaborate on what you want to investigate? maybe others
can help than?

IMO the files should simply be svn cp from the correct revision and then 
any functional and cosmetic changes can be applied seperately

you have several times suggested to simply rebuild the whole svn repo
which IMO is more intrusive then a svn cp, and anyway no history or
anything is lost by using svn cp, so i dont see how any of the
arguments agsinst cvs admin would apply ...


> 
> How long are you going to investigate this?
> It's 3'd day already.

iam curious too, i mean i surely understand that we are all busy but
* leaving unreviewable changes in cvs is a possible security issue
* the longer we wait the more tricky it will become to fix it as
  other stuff might get commited on top of these files

if you disagree that leaving cosmetic+functional mixed commits in cvs
for days is a security issue then i can demonstrate that it is ;)

and sorry for flaming, its just that our only way to prevent someone
from adding malicious code to svn is to review every change and a
more or less written rule against reversing bad changes makes that
very difficult

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is