[MPlayer-cvslog] r19324 - in trunk/stream: Makefile rtp.c rtp.h stream_rtp.c stream_udp.c udp.c udp.h

[Benjamin Zores]

On Sat, 5 Aug 2006 15:56:35 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> > +    unsigned int addr = inet_addr (url->hostname);
> > +    memcpy ((void *) &server_address.sin_addr, (void *) &addr, sizeof (addr));
> 
> why not 
> server_address.sin_addr.s_addr= addr;
> and what are the casts good for?
> 
> furthermore sin_addr is a struct containing a uint32_t here while
> you copy a sizeof(int) into it this doenst look too good IMO
> 
> and no i did not review the whole just scrolled through it ...

And i hadn't changed any functional part of the previous code (barely looked at it).
This is the original code, that's all.

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama