[MPlayer-cvslog] CVS: main m_config.c, 1.15, 1.16 m_config.h, 1.7, 1.8 m_option.c, 1.49, 1.50 m_option.h, 1.14, 1.15 m_property.c, 1.3, 1.4 m_property.h, 1.3, 1.4 m_struct.c, 1.4, 1.5 m_struct.h, 1.3, 1.4

[Diego Biurrun]

On Tue, Apr 25, 2006 at 09:14:57PM +0200, Alban Bedel wrote:
> On Tue, 25 Apr 2006 19:03:30 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > > -// Presets are mean to be used with options struct
> 
> That will be hard to fix now :) Otherwise i fixed most of the rest.
>  
> > Albeu, come on, you haven't used *a single* third person singular s in
> > that much text.  You can do better than that!
> 
> Sure i can, but generaly only for a short period of time. My brain simply
> have difficulties including rules that make no sense (as it just fuck the
> branch prediction ;). And most of the rules in human language are just that,
> old useless crap that is just there bcs it was already there before :(

Uh, oh, what do you have to say about French then?  It's much more
complex and illogical than English...

Besides, that does not excuse leaving out the plural s ;p

Don't get me wrong, I very much appreciate that you document stuff and
your English has improved markedly over the years.  But you know
yourself that it can still get better.  And if it does, we both benefit.

> > Before I sound too negative: It's excellent that you sat down and
> > documented all this code, three cheers :-)
> 
> Thanks :) Now it's my turn to complain ;) Next time could you keep the diff
> headers ? That would make things easier to read.

Yes, sorry, I figured that out myself after having gone through most of
the review, but it was too late :(  I'll keep them next time.

> If you could (at least sometimes) just commit the fix yourself that would
> also be nice. For you it is probably just trivial to do, where i often
> need a bit of thinking to find and fix the mistakes you pointed out.

I do that in fact, most of the time even.  But I also try to teach
everybody a bit and make them fix at least the recurring mistakes in the
hope that they will avoid them in the future.  I think so far it's
working just as it does for code reviews.  I was a bit terse with this
review as it's very long and the same issues keep repeating.  I wanted
to make a point for you to remember.  Whether this worked - I don't
know..

Also, don't forget that the code devs outnumber the docs devs 10:1 and
fixing everybody else's basic spelling/grammar mistakes is a lot of work
and not a terribly sexy thing to do...

Diego