[MPlayer-cvslog] CVS: main/libmpdemux cdda.c,1.21,1.22

Guillaume Poirier CVS syncmail at mplayerhq.hu
Sun Apr 23 17:14:05 CEST 2006


CVS change done by Guillaume Poirier CVS

Update of /cvsroot/mplayer/main/libmpdemux
In directory mail:/var2/tmp/cvs-serv1441

Modified Files:
	cdda.c 
Log Message:
resource leak fix.
detected by
Covertity's checker:
CID: 154
Checker: RESOURCE_LEAK
Description: Returned without freeing storage "cddb_info"


Index: cdda.c
===================================================================
RCS file: /cvsroot/mplayer/main/libmpdemux/cdda.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- cdda.c	18 Nov 2005 14:39:18 -0000	1.21
+++ cdda.c	23 Apr 2006 15:14:03 -0000	1.22
@@ -151,6 +151,7 @@
   if(!cdd) {
     mp_msg(MSGT_OPEN,MSGL_ERR,MSGTR_MPDEMUX_CDDA_CantOpenCDDADevice);
     m_struct_free(&stream_opts,opts);
+    free(cddb_info);
     return STREAM_ERROR;
   }
 
@@ -167,6 +168,7 @@
     mp_msg(MSGT_OPEN,MSGL_ERR,MSGTR_MPDEMUX_CDDA_CantOpenDisc);
     cdda_close(cdd);
     m_struct_free(&stream_opts,opts);
+    free(cddb_info);
     return STREAM_ERROR;
   }
 
@@ -222,6 +224,7 @@
     free(priv);
     cd_info_free(cd_info);
     m_struct_free(&stream_opts,opts);
+    free(cddb_info);
     return STREAM_ERROR;
   }
 




More information about the MPlayer-cvslog mailing list