[MPlayer-cvslog] CVS: main/osdep getch2-win.c,1.11,1.12

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Apr 17 11:44:46 CEST 2006


Hi,
On Sun, Apr 16, 2006 at 10:19:07PM -0400, Rich Felker wrote:
> There's a much nicer version that's not so damn long:
> 
> if ((unsigned)eventbuffer[i].Event.KeyEvent.wVirtualKeyCode - 0x70 <= 0x17)

And this and the next line would be even shorter by just adding int tmp
= ..., but why should I waste even one second for optimizing this code?
Look at the rest of it to see what I mean. If I ever happen to really
care I'd probably rewrite most of it anyway...
And am also unsure if MPlayer can really handle 39 F-Keys...

Greetings,
Reimar Döffinger




More information about the MPlayer-cvslog mailing list