[MPlayer-cvslog] CVS: main/libmpcodecs vf_screenshot.c,1.1,1.2

[Reimar Döffinger]

Hi,
On Sun, Sep 11, 2005 at 12:52:26PM +0200, Jindrich Makovicka CVS wrote:
> +static void get_image(struct vf_instance_s* vf, mp_image_t *mpi){
> +    vf->dmpi= vf_get_image(vf->next, mpi->imgfmt, 
> +			   mpi->type, mpi->flags, mpi->width, mpi->height);

Actually it would only be correct if you used mpi->flags | MP_IMGFLAG_READABLE.
In case you didn't do that on purpose, so no performance will be lost
(except on taking the screenshot itself), okay, but please add a
comment, saying that this actually is a hack. Otherwise sooner or later
somebody will use this filter as template and we will have another one that
doesn't work with -dr.

Greetings,
Reimar Döffinger