[MPlayer-cvslog] CVS: main/libvo vo_dfbmga.c,1.28,1.29

[Reimar Döffinger]

Hi,
On Wed, Oct 26, 2005 at 01:28:17PM +0200, Alban Bedel wrote:
> On Wed, 26 Oct 2005 09:41:44 +0200 (CEST)
> syncmail at mplayerhq.hu (Ville Syrjälä CVS) wrote:
[...]
> > +               case DIKS_MUTE:
> > +                    mplayer_put_key( 'm' );
> > +                    break;
> 
> This is definitly wrong, the user can map any command to the keys. Instead
> you should define new keycodes (in osdep/keycodes.h and input/input.c)
> and return those here. Then add some default bindings in input/input.c.

IMHO mp_input_queue_cmd is the function to use.

Greetings,
Reimar Döffinger