[MPlayer-cvslog] CVS: main/input input.c,1.123,1.124

[The Wanderer]

Reynaldo H. Verdejo CVS wrote:

> CVS change done by Reynaldo H. Verdejo CVS
> 
> Update of /cvsroot/mplayer/main/input
> In directory mail:/var2/tmp/cvs-serv23516/input
> 
> Modified Files:
> 	input.c 
> Log Message:
> translatable eng strings to new section on help_mp-en
> 
> Index: input.c

> @@ -470,7 +470,7 @@
>  int
>  mp_input_add_cmd_fd(int fd, int select, mp_cmd_func_t read_func, mp_close_func_t close_func) {
>    if(num_cmd_fd == MP_MAX_CMD_FD) {
> -    mp_msg(MSGT_INPUT,MSGL_ERR,"Too many command fds, unable to register fd %d.\n",fd);
> +    mp_msg(MSGT_INPUT,MSGL_ERR,MSGTR_INPUT_INPUT_ErrCantRegister2ManyCmdFds,fd);

I may be missing something, but - why does it make sense to have INPUT
repeated twice in the MSGTR name? The only guess I can make is "because
this is in not only in the input section but is in the file input.c",
but that doesn't seem like a sufficiently important association to
warrant noting in the name - especially not when the result is this
awkward.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.