[MPlayer-cvslog] CVS: main mencoder.c,1.308,1.309

[Diego Biurrun]

On Thu, Oct 13, 2005 at 11:34:37PM +0200, Oded Shimon wrote:
> On Thu, Oct 13, 2005 at 05:33:39PM -0400, Rich Felker wrote:
> > On Thu, Oct 13, 2005 at 10:27:50PM +0200, Oded Shimon CVS wrote:
> > > 
> > > Modified Files:
> > > 	mencoder.c 
> > > Log Message:
> > > weirdness, flags aren't restored right unless you add this second push
> > > mencoder a.avi b.avi -flag c.avi
> > > 
> > > -flag should've only applied to b, but it applied to both b and c!!
> > > 
> > > No clue why this happens and more so why this solves it. but it does.
> > 
> > I don't think committing hackish "no clue why it works" bugfixes is
> > considered appropriate...
> 
> Well, isn't it better than keeping the "it doesn't work"? :/

I agree with Rich.  At least send a patch first.

> It's a relatively small hack, maybe i should've commented it...

Most definitely.

Diego