[MPlayer-cvslog] CVS: main/libvo vo_directx.c,1.59,1.60

[Joey Parrish]

On Tue, Nov 15, 2005 at 10:19:33PM +0100, Reimar Döffinger wrote:
> On Fri, Nov 11, 2005 at 11:52:49AM -0600, Joey Parrish wrote:
> > On Fri, Nov 11, 2005 at 06:12:35PM +0100, Alexander Strasser wrote:
> > > Joey Parrish CVS wrote:
> > > > CVS change done by Joey Parrish CVS
> > > > Modified Files:
> > > > 	vo_directx.c 
> > > > Log Message:
> > > > Intercept maximize event and go into fullscreen mode.
> > > > 
> > >   Is it necesarry? I know that some windows users expect this
> > > strange behaviour for movie players, but it makes it impossible
> > > to maximize the window except doing it by hand.
> > >   At least making it configurable so that normal window handling
> > > can take place would IMHO be better.
> > >   Btw IIRC wmp doesn't do it this way, so at least it is not that
> > > uncommon to not switch to fullscreen when maximize is requested.
> > 
> > I got a number of requests for this feature in private mails, so I
> > tried it in my packages months ago.  It's not strictly neccessary,
> > though.  Do you have a suggestion for an option name for this behavior?
> > Should it be an mplayer option or a vo_directx option?
> 
> Actually, since we did it for the close button (AFAIK), why not making
> it an event, too, that the user can choose in input.conf what it should
> do?

Agreed.  That's the most flexible solution.  If there are no objections,
I'll commit such a thing shortly.

--Joey

-- 
"There are trivial truths and there are great truths.  The opposite of a
trivial truth is plainly false.  The opposite of a great truth is also true."
  --Neils Bohr