[MPlayer-cvslog] CVS: main mplayer.c,1.882,1.883

[Diego Biurrun]

On Sun, Nov 06, 2005 at 03:44:52PM +0100, Tobias Diedrich CVS wrote:
> 
> +      osd_show_av_delay = sh_video->fps/2;
> +      osd_show_sub_delay = sh_video->fps/2; // show the subdelay in OSD
> +      osd_show_sub_delay = sh_video->fps/2; // show the subdelay in OSD
> +	  osd_show_status = sh_video->fps/2;
> +       osd_show_framedropping=sh_video->fps/2;
> +       osd_show_ontop=sh_video->fps/2;
> +       osd_show_rootwin=sh_video->fps/2;
> +        osd_show_sub_pos = sh_video->fps/2;
> +	osd_show_sub_alignment = sh_video->fps/2;
> +	osd_show_sub_visibility = sh_video->fps/2; // show state of subtitle visibility in OSD
> +                osd_show_dvd_nav_highlight=sh_video->fps/2;

Why not use a common variable/#define/whatever instead of repeating the
sh_video->fps/2 calculation?

Diego