[MPlayer-cvslog] CVS: main/libmpdemux demux_mkv.c,1.43,1.44

[Rich Felker]

On Mon, May 23, 2005 at 09:20:57AM +0200, Moritz Bunkus wrote:
> Hey,
> 
> On Sunday 22 May 2005 17:28, Rich Felker wrote:
> > What if they have different vorbis comments but otherwise the same
> > codebook? I expect this might be common, if idiots have stored the
> > language in the vorbis comment as well as the mkv header..
> 
> Then switching will not work. Before Nico's patch changing Vorbis'
> private data the mkv demuxer could have checked the codebook only, but
> that patch removed the decoding of the track's CodecPrivate. So for
> audio switching it would have to be added back.

A much simpler version of it could be added back. But IMO we should
just make a signal that can be sent to the audio decoder to
reinitialize. MPlayer itself only requires the output audio format to
stay fixed, not the codec parameters, and the vorbis decoder could
clearly reinitialize itself with new headers if given a command to do
so.

Rich