[MPlayer-cvslog] CVS: main/libmpcodecs ve_lavc.c,1.113,1.114

[Michael Niedermayer]

Hi

On Sunday 08 May 2005 12:31, Reimar Döffinger CVS wrote:
> CVS change done by Reimar Döffinger CVS
>
> Update of /cvsroot/mplayer/main/libmpcodecs
> In directory mail:/var2/tmp/cvs-serv28600
>
> Modified Files:
> 	ve_lavc.c
> Log Message:
> ljpeg codec needs YUVJ colorspace, too
>
>
> Index: ve_lavc.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpcodecs/ve_lavc.c,v
> retrieving revision 1.113
> retrieving revision 1.114
> diff -u -r1.113 -r1.114
> --- ve_lavc.c	30 Apr 2005 22:41:41 -0000	1.113
> +++ ve_lavc.c	8 May 2005 10:31:33 -0000	1.114
> @@ -614,7 +614,8 @@
>      {
>  	case IMGFMT_YV12:
>  	    // HACK, mjpeg accepts PIX_FMT_YUV420P only with vstrict=-1
> -	    if (strcasecmp(lavc_param_vcodec, "mjpeg") == 0)
> +	    if (strcasecmp(lavc_param_vcodec, "mjpeg") == 0 ||
> +	        strcasecmp(lavc_param_vcodec, "ljpeg") == 0)
>  	      lavc_venc_context->pix_fmt = PIX_FMT_YUVJ420P;

reverse this! and the 1.108 -> 1.109 change too
the correct way to store IMGFMT_YV12 in jpeg is to set strict=-1
the difference is that your (stupid) hack leads to wrong colors on all encoded 
mjpeg&ljpeg as libavcodec wont know the correct colorspace and so cant store 
the correct colorspace in the jpeg

[...]
-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond