[MPlayer-cvslog] CVS: main/libmpdemux demux_ogg.c,1.69,1.70

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 04 May 2005 at 03:35, Joey Parrish wrote:
> On Wed, May 04, 2005 at 02:49:37AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 02 May 2005 at 09:59, Reimar Döffinger CVS wrote:
> > > @@ -756,6 +756,7 @@
> > >    clear_sub = -1;
> > >    s = demuxer->stream;
> > >  
> > > +  demuxer->priv =
> > >    ogg_d = (ogg_demuxer_t*)calloc(1,sizeof(ogg_demuxer_t));
> > >    sync = &ogg_d->sync;
> > >    page = &ogg_d->page;
> > 
> > I haven't tried to compile this yet, but I'm pretty certain that this won't
> > compile without an initial value and a semicolon. Surely you meant
> > > +  demuxer->priv = ogg_d;
> > didn't you?
> 
> The newline doesn't matter.  It is effectively the same as:
> demuxer->priv = ogg_d = (ogg_demuxer_t*)calloc(1,sizeof(ogg_demuxer_t));
> 
> Both demuxer->priv and ogg_d will have the same value.

You are correct. However, this would've been much more readable without
the newline.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"