[MPlayer-cvslog] CVS: main/libvo vo_macosx.m, 1.3, 1.4 vo_macosx.h, 1.1, 1.2

Diego Biurrun diego at biurrun.de
Tue May 3 00:39:22 CEST 2005


On Mon, May 02, 2005 at 08:31:28PM +0200, Reimar Döffinger wrote:
> On Mon, May 02, 2005 at 08:06:02PM +0200, Nicolas Plourde CVS wrote:
> > @@ -477,10 +482,13 @@
> >  	//go fullscreen
> >  	if(vo_fs)
> >  	{
> > -		//hide menubar and mouse if fullscreen on main display
> > -		HideMenuBar();
> > -		HideCursor();
> > -		mouseHide = YES;
> > +		if(!isRootwin)
> > +		{
> > +			//hide menubar and mouse if fullscreen on main display
> > +			HideMenuBar();
> > +			HideCursor();
> > +			mouseHide = YES;
> > +		}
> 
> Please avoid such cosmetics - if neccessary apply them seperately.

Depends on the definition of cosmetics..  He added an if().  I faintly
remember flaming Alexander Strasser for sending a patch with similar
cosmetics.  In the end I think it was decided that it was OK.

Diego




More information about the MPlayer-cvslog mailing list