[MPlayer-cvslog] CVS: main mencoder.c,1.289,1.290

[Alexander Strasser]

Oded Shimon wrote:
> On Wed, Jun 29, 2005 at 01:02:01AM -0400, Rich Felker wrote:
> > On Mon, Jun 27, 2005 at 09:10:14PM +0200, Nico Sabbi CVS wrote:
> > > CVS change done by Nico Sabbi CVS
[...]
> > > -static short edl_skip; ///< -1 OR the value of in_size of an already read frame.
> > > +static int edl_skip; ///< -1 OR the value of in_size of an already read frame.
> > 
> > Why are there any shorts?!?! short should NEVER be used except in
> > array/pointer type for addressing 16-bit buffers. 100l to whoever
> > wrote that (oded?? ;)
> 
> Yes that was me, they are only flags. so, umm, change to int?..

  That they are flags is no reason to make em shorter in most
cases. The traditional approach was to just use int, but recent
64bit decisions made the (i think original reasoning) backwards
and you are best placed at the moment using long or some special
types introduced in newer standards afaict.

  Alex (beastd)