[MPlayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.148,1.149

[Michael Niedermayer]

Hi

On Wednesday 29 June 2005 06:58, Rich Felker wrote:
> On Sun, Jun 26, 2005 at 10:28:15PM +0200, Roberto Togni CVS wrote:
> > CVS change done by Roberto Togni CVS
> >
> > Update of /cvsroot/mplayer/main/libmpcodecs
> > In directory mail:/var2/tmp/cvs-serv3803/libmpcodecs
> >
> > Modified Files:
> > 	vd_ffmpeg.c
> > Log Message:
> > FFmpeg theora decoder support
> > It works only with libavformat demuxer
> >
> >
> > Index: vd_ffmpeg.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/libmpcodecs/vd_ffmpeg.c,v
> > retrieving revision 1.148
> > retrieving revision 1.149
> > diff -u -r1.148 -r1.149
> > --- vd_ffmpeg.c	8 Jun 2005 07:05:49 -0000	1.148
> > +++ vd_ffmpeg.c	26 Jun 2005 20:28:12 -0000	1.149
> > @@ -336,7 +336,8 @@
> >  	 sh->format == mmioFOURCC('F','L','I','C') ||
> >  	 sh->format == mmioFOURCC('S','N','O','W') ||
> >  	 sh->format == mmioFOURCC('a','v','c','1') ||
> > -	 sh->format == mmioFOURCC('L','O','C','O')
> > +	 sh->format == mmioFOURCC('L','O','C','O') ||
> > +	 sh->format == mmioFOURCC('t','h','e','o')
> >           ))
> >      {
> >  	avctx->extradata_size = sh->bih->biSize-sizeof(BITMAPINFOHEADER);
>
> is there a reason this is special-cased for every codec that needs
> extradata? 

dunno


> imo extradata should always be passed to lavc if it's 
> present (if sh->bih->biSize>sizeof(BITMAPINFOHEADER))..

agree

[...]
-- 
Michael