[MPlayer-cvslog] Re: CVS: main/postproc swscale_template.c, 1.116, 1.117

[Guillaume POIRIER]

Hi,

On 6/28/05, Tobias Diedrich <ranma at tdiedrich.de> wrote:
> Tobias Diedrich wrote:
> 
> > It redefines "inline" as "inline __attribute__((always_inline))".
> > If I add "#define inline inline __attribute__((always_inline))" at
> > the top of swscale_template.c it works with gcc-3.3 and the MMX2
> > code no longer segfaults.
> 
> Since reimar says it doesn't work for him, here is the patch and
> exact gcc version + command line tested:
> 
> ranma at nukunuku:~/src/mplayer-cvs/main-rw/postproc$ dpkg -l gcc-3.3
> Desired=Unknown/Install/Remove/Purge/Hold
> | Status=Not/Installed/Config-files/Unpacked/Failed-config/Half-installed
> |/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad)
> ||/ Name           Version        Description
> +++-==============-==============-============================================
> ii  gcc-3.3        3.3.5-13       The GNU C compiler
> ranma at nukunuku:~/src/mplayer-cvs/main-rw/postproc$ gcc --version
> gcc (GCC) 3.3.5 (Debian 1:3.3.5-13)
> Copyright (C) 2003 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> ranma at nukunuku:~/src/mplayer-cvs/main-rw/postproc$ cvs -z3 diff -u swscale_template.c
> ranma at mplayer.dev.hu's password:
> Index: swscale_template.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/postproc/swscale_template.c,v
> retrieving revision 1.117
> diff -u -r1.117 swscale_template.c
> --- swscale_template.c  24 Jun 2005 12:17:30 -0000      1.117
> +++ swscale_template.c  27 Jun 2005 22:23:25 -0000
> @@ -16,6 +16,8 @@
>      Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>  */
> 
> +#define inline inline __attribute__((always_inline))
> +
>  #undef REAL_MOVNTQ
>  #undef MOVNTQ
>  #undef PAVGB

This fixed the crash on my machine with gcc-3.3. Is it a desirable fix?

Guillaume
-- 
A woman isn't complete without a man.
But where do you find a man - a real man - these
days?
  -- Lauren Bacall
My answer: Only at #mplayerdev on the freenode IRC network.