[MPlayer-cvslog] CVS: main/postproc swscale_template.c, 1.116, 1.117

[Michael Niedermayer]

Hi

On Sunday 26 June 2005 21:10, Jindrich Makovicka wrote:
> Guillaume Poirier CVS wrote:
> > CVS change done by Guillaume Poirier CVS
> >
> > Update of /cvsroot/mplayer/main/postproc
> > In directory mail:/var2/tmp/cvs-serv19376/postproc
> >
> > Modified Files:
> > 	swscale_template.c
> > Log Message:
> > Fixes GCC4 fix by using "g" instead of "mp" as some compilers misscompile
> > that code othewisei (leading to segfaults).
>
> This is IMHO no miscompilation. If you instruct asm() to expect a 64-bit
> memory operand, and you supply only 32-bit one, typecasted to 64-bit, a
> lot of mess can happen. 

with gcc yes, otherwise no, either the compiler can create a 64 bit temporary 
variable on the stack and use it or it should fail with a fatal error

but its not as simple as just saying "the developer should put things in 
correctly sized variables" because this leads not only to obfuscated and hard 
to read source code but also to slow code if the compiler fails to remove the 
redundant stuff

[...]

-- 
Michael