[MPlayer-cvslog] CVS: main parser-mecmd.c, 1.8, 1.9 parser-mpcmd.c, 1.20, 1.21

[Rich Felker]

On Wed, Jun 08, 2005 at 10:05:05AM +0200, Reimar Döffinger wrote:
> Hi,
> On Wed, Jun 08, 2005 at 12:46:22AM -0400, Rich Felker wrote:
> > On Sat, Apr 23, 2005 at 10:41:21PM +0200, Reimar Döffinger CVS wrote:
> > > CVS change done by Reimar Döffinger CVS
> > > 
> > > Update of /cvsroot/mplayer/main
> > > In directory mail:/var2/tmp/cvs-serv9427
> > > 
> > > Modified Files:
> > > 	parser-mecmd.c parser-mpcmd.c 
> > > Log Message:
> > > Make "mplayer -- --a" play the file --a instead of bailing out with a useless
> > > error message
> > 
> > please reverse this. it's totally against the design for mplayer's
> > command line system, which relies on being able to have options
> > _after_ the filename! instead one can use mplayer file://--a so it's
> > totally pointless!
> 
> Reversing this will _not_ change that! I think what you want is removing
> the support for the -- param meaning "no flags behind this point". I
> can't see what advantage that would have though...

OK, that's what I meant. I didn't know this nonsense was already in
there.. Sorry.

> Either you do mplayer -- --a and you wont be able to specify options
> after the filename but at least it will work, or you require the user to
> find the mplayer file://--a syntax, in which case he can specify options
> after it (even if he doesn't want that at all).
> The main point of this patch was that doing something like
> mplayer file.avi --loop
> (i.e. accidently typing two -- instead of one) doesn't give this
> message (which is completely confusing, wrong etc):
> 
> '--' indicates no more options, but no filename was given on the command
> line.
> 
> but instead this one (which is still confusing, but more to the point):
> 
> Unknown option on the command line: -loop

Indeed, still confusing.. The "unknown option" thing should print the
leading "-" too so it says:

Unknown option on the command line: --loop

Rich