[MPlayer-cvslog] CVS: main mencoder.c,1.298,1.299

[Reimar Döffinger]

Hi,
On Fri, Jul 22, 2005 at 07:52:34PM +0200, Attila Kinali wrote:
> On Mon, 18 Jul 2005 21:59:05 +0200 (CEST)
> syncmail at mplayerhq.hu (Alex Beregszaszi) wrote:
> > catch HUP and PIPE signals aswell. Patch by Sergey Khlutchin (@gmail.com)
> [...]
> > +signal(SIGHUP,exit_sighandler);  // broken terminal line
> > +signal(SIGPIPE,exit_sighandler); // broken pipe
> 
> IMHO this is useless. Both SIGHUP and SIGPIPE default
> to SIGTERM if they are not caught (see "man 7 signal").
> This breaks compilation on windows, see

1) I already fixed
2) They do not default to SIGTERM, it defaults to terminating the
process (i.e. the thing that SIGKILL would do, which has very bad side
effects like broken terminal, the cache process not being terminated
etc., see also http://bugzilla.mplayerhq.hu/show_bug.cgi?id=56,
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=179)

Greetings,
Reimar Döffinger