[MPlayer-cvslog] CVS: main/libmpdemux ebml.c,1.4,1.5

[Michael Niedermayer]

Hi

On Tuesday 19 July 2005 15:43, Ivan Kalvachev wrote:
> On 7/17/05, Alex Beregszaszi <alex at fsn.hu> wrote:
> > Hi,
> >
> > > > Conclusion: I think that for gcc >= 3 we should just add
> > > > -fno-strict-aliasing to the CFLAGS, this should also fix some
> > > > problems we had with mp3lib, libmpeg2 and libfaad.
> > > > Do you agree?
> > >
> > > agree totally. aliasing rules suck. i'm against all this union
> > > nonsense.
> >
> > Actually I like the union approach, if it's not scrambled and written
> > well.
>
> I think I had offered this before. create an stream_read_float4()
> function and encapsulate the union there.
> More readable and clean solution.

thats possible but not portable, see av_{flt|dbl}2int() and av_int2{flt|dbl}() 
in libavcodec/utils.c for how to do this in a hopefully much more portable 
way

[...]
-- 
Michael