[MPlayer-cvslog] CVS: main/libmpcodecs ad_faad.c,1.19,1.20

[Reimar Döffinger]

Hi,
On Sat, Jul 16, 2005 at 12:09:32AM +0200, Guillaume Poirier CVS wrote:
> memcpy and memmove both copy memory, but when using memcpy the source and destination must not overlap, but here, they did overlap.
> Committed with the kind blessing of Richard, patch by uau

A shorted explanation would probably have done in this case, too :-)


> -      memcpy(sh->a_in_buffer,&sh->a_in_buffer[faac_finfo.bytesconsumed],sh->a_in_buffer_len);
> +      memmove(sh->a_in_buffer,&sh->a_in_buffer[faac_finfo.bytesconsumed],sh->a_in_buffer_len);

Hmm... I wonder, would it be time to implement a fast memmove? Didi we o
this kind of replacements where fastmemcpy.h was included?

Greetings,
Reimar Döffinger