[MPlayer-cvslog] CVS: main/libmpcodecs vf_pp7.c, NONE, 1.1 vf.c, 1.115, 1.116 Makefile, 1.144, 1.145

[Rich Felker]

On Mon, Jul 11, 2005 at 12:42:37PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Monday 11 July 2005 06:24, Rich Felker wrote:
> > On Sat, Jul 09, 2005 at 09:49:53AM +0200, Michael Niedermayer CVS wrote:
> > > static void dctB_mmx(DCTELEM *dst, DCTELEM *src){
> > >     asm volatile (
> [...]
> > needs #ifdef around it... (breaks compile on non-x86!!)
> 
> fixed
> 
> 
> >
> > > static void get_image(struct vf_instance_s* vf, mp_image_t *mpi){
> > >     if(mpi->flags&MP_IMGFLAG_PRESERVE) return; // don't change
> > >     // ok, we can do pp in-place (or pp disabled):
> > >     vf->dmpi=vf_get_image(vf->next,mpi->imgfmt,
> > >         mpi->type, mpi->flags, mpi->w, mpi->h);
> > >     mpi->planes[0]=vf->dmpi->planes[0];
> > >     mpi->stride[0]=vf->dmpi->stride[0];
> > >     mpi->width=vf->dmpi->width;
> > >     if(mpi->flags&MP_IMGFLAG_PLANAR){
> > >         mpi->planes[1]=vf->dmpi->planes[1];
> > >         mpi->planes[2]=vf->dmpi->planes[2];
> > >         mpi->stride[1]=vf->dmpi->stride[1];
> > >         mpi->stride[2]=vf->dmpi->stride[2];
> > >     }
> > >     mpi->flags|=MP_IMGFLAG_DIRECT;
> > > }
> >
> > this is incorrect. dr must be disabled if the dmpi buffer obtained is
> > not in readable memory, otherwise it will be slow as hell.. i would
> 
> IIRC i copy & pasted this from vf_spp.c which was copy&pasted from vf_pp.c 
> which was written by arpi ...
> 
> would 
> vf->dmpi=vf_get_image(vf->next,mpi->imgfmt, mpi->type, 
>    mpi->flags | MP_IMGFLAG_READABLE, mpi->w, mpi->h);
> 
> fix this or should i simply remove get_image()

i think it will fix the problem, yes.

rich