[MPlayer-cvslog] CVS: main/libmpdemux ebml.c,1.4,1.5

[Rich Felker]

On Mon, Jul 11, 2005 at 10:16:54AM +0200, Reimar Döffinger wrote:
> Hi,
> On Sun, Jul 10, 2005 at 08:31:15PM +0200, Moritz Bunkus CVS wrote:
> > Fix for gcc 4 and strict-aliasing. Patch by Uoti A Urpala ( urpala () cc ! helsinki ! fi ).
> 
> I don't really agree with this patch.
> 1) this by far isn't the only place where we break strict-aliaing
> 2) It makes the code more complicated (which is also true for that
> (float *) (void *) that was there before)
> 3) from what I read somewhere else, this code code _still_ does not
> behave according to strict aliasing rules, you would have to assing the
> pointer to a void* variable first.
> 
> Conclusion: I think that for gcc >= 3 we should just add
> -fno-strict-aliasing to the CFLAGS, this should also fix some problems
> we had with mp3lib, libmpeg2 and libfaad.
> Do you agree?

agree totally. aliasing rules suck. i'm against all this union
nonsense.

rich