[MPlayer-cvslog] CVS: main/libmpcodecs vf_expand.c,1.29,1.30

[Reimar Döffinger]

Hi,
On Thu, Jul 07, 2005 at 09:55:00PM +0200, Oded Shimon CVS wrote:
> add 'aspect' and 'round' params to vf_expand.
> (my first commit! I hope I did this correctly ;)

Well, I would have prefered a clear warning that you would commit before
doing it, I would have taken the time to review it then.

> +    	vf->priv->exp_w = (1 + (vf->priv->exp_w - 1) / vf->priv->round) * vf->priv->round;
> +        vf->priv->exp_h = (1 + (vf->priv->exp_h - 1) / vf->priv->round) * vf->priv->round;

Broken indetation, and also: what on earth are you trying to do with
that code?? simply rounding down? Then just do
vf->priv->exp_w -= vf->priv->exp_w % vf->priv->round;

Greetings,
Reimar Döffinger