[MPlayer-cvslog] CVS: main/postproc swscale_template.c, 1.109, 1.110

[Reimar Döffinger]

Hi,
On Wed, Jan 19, 2005 at 09:02:16PM +0100, Aurelien Jacobs wrote:
> On Wed, 19 Jan 2005 13:56:19 +0100 (CET)
> syncmail at mplayerhq.hu (Reimar Döffinger CVS) wrote:
> 
> > CVS change done by Reimar Döffinger CVS
> > 
> > Update of /cvsroot/mplayer/main/postproc
> > In directory mail:/var2/tmp/cvs-serv19984
> > 
> > Modified Files:
> > 	swscale_template.c 
> > Log Message:
> > 100l, fix broken AMD64 patch. To whoever applied it: Did you actually _try_
> > to check if it's correct??
> 
> Yes I tried to check lots of things but not anything. There are so much
> possibilities that's it's almost impossible.
> Anyway I use mplayer on x86_64 every day and didn't encountered any bug.
> Nice that you've caught one. Thus I tested -vf scale with -sws 0 and
> indeed it crash on x86_64. And your fix is not enough. There is a call
> to some "funnyCode" which seem to be generated at runtime by
> initMMX2HScaler. I've not ported this generated code and so it crash.
> I will try to have a deeper look at this one day.

I complained because it was a _really_ stupid typo, a lowercase d
instead of an uppercase one, so there even was the same thing twice in
the clobber list. And it broke code that was working before.
If some things are not supported on AMD64, well, such is life ;-)

Greetings,
Reimar Döffinger