[MPlayer-cvslog] CVS: main/libvo vo_jpeg.c,1.23,1.24

[Reimar Döffinger]

Hi,
On Sun, Jan 16, 2005 at 12:56:07PM +0100, Arpi wrote:
> > +static int int_zero_hundred(int *val)
> > +{
> > +    if ( (*val >=0) && (*val<=100) )
> > +        return 1;
> > +    return 0;
> 
> > +        {"optimize",    OPT_ARG_INT,    &jpeg_optimize,
> > +                                                (opt_test_f)int_zero_hundred},
> > +        {"smooth",      OPT_ARG_INT,    &jpeg_smooth,
> > +                                                (opt_test_f)int_zero_hundred},
> > +        {"quality",     OPT_ARG_INT,    &jpeg_quality,
> > +                                                (opt_test_f)int_zero_hundred},
> 
> what's this mess ??????
> why didnt you adopt the same config struct used in main commandline parser,
> or even better, the cfg.h one from G2 instead of this?
> (i mean the flags, min, max fields)

Because min and max are not enough, they can't be used e.g. for strings
and cannot check more complex relations. It sure isn't perfect but not a
mess (that's what it was before).
Anyway, it is not impossible to change it and some things will be
changed, but for now this is a big improvement.

Greetings,
Reimar Döffinger