[MPlayer-cvslog] CVS: main/libvo vo_zr2.c,1.5,1.6

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jan 8 15:50:28 CET 2005


Hi,
On Sat, Jan 08, 2005 at 03:25:24PM +0100, Rik Snel CVS wrote:
> +	char dev_arg_str[256];

> +	/* interpret the strings we got from subopt_parse */
> +	if (norm_arg.len) norm = get_norm(&norm_arg);
> +	if (dev_arg.len) {  /* produce a proper ASCIIZ from dev_arg */
> +		memcpy(dev_arg_str, dev_arg.str, dev_arg.len);
> +		dev_arg_str[dev_arg.len] = '\0';
> +		dev = dev_arg_str;

I know currently len can't be bigger than 255, but I and Alexander
decided that this should be changed, e.g. because it is often used for
paths which can easily be larger...
So if you have the time please use then strndup-like way that is used in
other places (like vo_yuv4mpeg I think).

Greetings,
Reimar Döffinger




More information about the MPlayer-cvslog mailing list