[MPlayer-cvslog] CVS: main/libao2 ao_pcm.c,1.24,1.25

[Reimar Döffinger]

Hi,

On Mon, Jan 03, 2005 at 11:06:30AM +0100, Reimar Döffinger wrote:
> On Mon, Jan 03, 2005 at 01:57:45AM +0100, Felix Buenemann wrote:
> > On Sunday 02 January 2005 23:38, Reimar Döffinger wrote:
> > > On Sun, Jan 02, 2005 at 11:07:17PM +0100, Felix Buenemann wrote:
> > > > On Sunday 02 January 2005 15:41, Reimar Döffinger CVS wrote:
> > > > > Modified Files:
> > > > >         ao_pcm.c
> > > > > Log Message:
> > > > > Add -ao pcm suboptions and remove -aofile and -waveheader options.
> > > > > Base on idea by Olivier Rolland (billl at users dot sf dot net)
> > > >
> > > > The code is not equivalent to old behaviour, now if you specify no
> > > > waveheader, then filename will be audiodump.wav not audiodump.pcm...
> > >
> > > I know. Maybe I should have mentioned it - but like this it is at least
> > > consistent with the manpage.
> > > I can think of a way to make it behave like before, but it's a bit
> > > complicated. Do you think it is necessary?
> > yes, I'd be rather irritated playing a file audiodump.wav with an application 
> > capable of playing wave-files and it will throw up "unsupported file" or 
> > something. While if it's named audiodump.pcm I'll make up my mind what it 
> > is...
> 
> Does the attached patch look okay?

applied.

Greetings,
Reimar Döffinger